fix: KTO evaluation iterates wrong dataloader - #6405
Closed
Mr-Neutr0n wants to merge 1 commit into
Closed
Conversation
Author
|
Closing this one to tidy up my open pull requests. It's been open around five months with no review activity, and I'd rather withdraw it than leave it sitting in your queue. Nothing needed from you, and no hard feelings at all. If the fix is still wanted, this can be reopened, or I'm happy to redo it properly against current main. Apologies for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The KTO trainer's evaluation method iterates over
train_dataloaderinstead ofeval_dataloader, causing evaluation metrics to be computed on training data rather than validation data.Fix
Changed the evaluation loop to use
eval_dataloader.